edu.internet2.middleware.grouper.*Save API's should have constructor/methods to set the session to use for the operation.

XMLWordPrintable

    • Type: Improvement
    • Resolution: Won't Fix
    • Priority: Minor
    • 2.5.55
    • Affects Version/s: 2.5.52
    • Component/s: None
    • None

      Please review all of the edu.internet2.middleware.grouper.*Save.java classes.

      They all could use a constructor that passes in the session for the object to use.
      *Save(GrouperSession session_to_use) {...}

      These already support it, but not all of them do.
      StemSave, GroupSave
      https://github.com/Internet2/grouper/blob/99cd2a64a853fea5c8a672e282115dcb76bee978/grouper/src/grouper/edu/internet2/middleware/grouper/StemSave.java#L135

      https://github.com/Internet2/grouper/blob/99cd2a64a853fea5c8a672e282115dcb76bee978/grouper/src/grouper/edu/internet2/middleware/grouper/GroupSave.java#L243

      Likewise the pattern of .assignRunAsRoot(boolean) would be good to also replicate to all of these classes.

            Assignee:
            Chris Hyzer (upenn.edu)
            Reporter:
            Carey Black (osu.edu) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: